net icon indicating copy to clipboard operation
net copied to clipboard

x/net/http2:Enable HTTP/2 CLIENTs to receive and send unknown frames

Open soya3129 opened this issue 4 years ago • 2 comments

This change enables HTTP/2 CLIENTs to receive and send unknown frames. The basic idea is to add unknown frame handling in request.Body and response.Body. If the APIs look OK, I will add more tests.

Note that, this PR is for client side review only. The change is in transport.go and transport_test.go. This PR also includes change on the server side in order to run tests, and those server side change is under review in https://github.com/golang/net/pull/78, and can be ignored for review in this PR. Those server side change includes server.go, server_test.go, frame.go, write.go.

Thank @tombergan for the initial feedback!

For golang/go#40359

soya3129 avatar Jul 26 '20 08:07 soya3129

cc @birenroy @ianswett

soya3129 avatar Jul 26 '20 08:07 soya3129

This PR (HEAD: e3b5b50ba0ffc416c6b412ef83b1fc98a2f2713e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/244800 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jul 26 '20 08:07 gopherbot