net
net copied to clipboard
golang
trace: make maximum active traces configurable
This commit adds a "max_active" query param to net/trace's /debug/requests
HTTP handler. When provided, the parameter configures the maximum number of
active traces to show. This allows users to override the default max value
of 20, which was previously a constant value enforced by maxActiveTraces.
This PR (HEAD: e0d3da478568d161f0203612401290ce14f6cfc0) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/222675 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Nathan VanBenschoten:
Patch Set 1:
Friendly ping. It doesn't look like there's a current owner of /x/net/trace so I'm not sure who to route this change to for review. It's a small but potentially high-impact improvement to observability.
Please don’t reply on this GitHub thread. Visit golang.org/cl/222675. After addressing review feedback, remember to publish your drafts!
@bradfitz any chance you'd be willing to give this small patch a review? The engineers at CockroachDB have found that this change improves the utility of net/trace's /debug/requests page significantly for debugging distributed deadlocks.