net
net copied to clipboard
golang
x/net/websocket: add example of (*Server).Handshake
The existing (*Server).Handshake lacks examples of how it is used, so add runnable and testable versions of them
Fixes golang/go#32866
This PR (HEAD: 136aed7fdadcffafcbc0bb05693231a3761982c4) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/190819 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 74dc6eaac4c2b08b7ca5df4d10531b59d2777d0f) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/190819 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 45fbd289f03989542fc9fbdf0738fd9f539cd2de) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/190819 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Andrew Bonventre:
Patch Set 4: Run-TryBot+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 4:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=3f210d2b
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 4:
Build is still in progress... This change failed on freebsd-amd64-12_0: See https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 4: TryBot-Result-1
9 of 10 TryBots failed: Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/1820cca7/windows-amd64-2016_3f265617.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/0c076032/linux-amd64_76365e6e.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/1820cca7/openbsd-amd64-64_1fd14079.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64_784d376c.log Failed on linux-386: https://storage.googleapis.com/go-build-log/1820cca7/linux-386_7912202a.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/1820cca7/windows-386-2008_4706fff8.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64-race_90180f1c.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/1820cca7/android-amd64-emu_6a8d3e84.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=3f210d2b
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4:
Build is still in progress... This change failed on freebsd-amd64-12_0: See https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4: TryBot-Result-1
9 of 10 TryBots failed: Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/1820cca7/windows-amd64-2016_3f265617.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/0c076032/linux-amd64_76365e6e.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/1820cca7/openbsd-amd64-64_1fd14079.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64_784d376c.log Failed on linux-386: https://storage.googleapis.com/go-build-log/1820cca7/linux-386_7912202a.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/1820cca7/windows-386-2008_4706fff8.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64-race_90180f1c.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/1820cca7/android-amd64-emu_6a8d3e84.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 4: Run-TryBot+1
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=3f210d2b
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4:
Build is still in progress... This change failed on freebsd-amd64-12_0: See https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log
Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 4: TryBot-Result-1
9 of 10 TryBots failed: Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/1820cca7/freebsd-amd64-12_0_222f1b44.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/1820cca7/windows-amd64-2016_3f265617.log Failed on linux-amd64 (Go 1.13.x): https://storage.googleapis.com/go-build-log/0c076032/linux-amd64_76365e6e.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/1820cca7/openbsd-amd64-64_1fd14079.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64_784d376c.log Failed on linux-386: https://storage.googleapis.com/go-build-log/1820cca7/linux-386_7912202a.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/1820cca7/windows-386-2008_4706fff8.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/1820cca7/linux-amd64-race_90180f1c.log Failed on android-amd64-emu: https://storage.googleapis.com/go-build-log/1820cca7/android-amd64-emu_6a8d3e84.log
Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!
Message from Andrew Bonventre:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/190819. After addressing review feedback, remember to publish your drafts!