net
net copied to clipboard
golang
net: avoid allocation for trace context
Using a string as the context key leads to boxing overhead. See profile: https://www.dropbox.com/s/9u74uvpq8vowwdo/Screenshot%202019-07-30%2012.39.20.png?dl=0
This PR (HEAD: 38b501a80b832e47bbdac17d796acd9a485e7ff7) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/188177 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: e7606ae14c3482f537a7f1bd5bb16f306b41d889) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/188177 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Ian Lance Taylor:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: a6d51a4ea4c96a6477da3d3ec9ff39a3d0ab899a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/188177 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Ian Lance Taylor:
Patch Set 3: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 3:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=0712b588
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 3: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 3:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=0712b588
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 3: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/188177. After addressing review feedback, remember to publish your drafts!