net
net copied to clipboard
golang
golang.org/x/net: have conflict with path "GET /"
This PR (HEAD: 66d1666620a7520a3b7bcd915da3a51ea76cdd8d) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/621176.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
actually, i don't understand some point. why does the multi is true when rest is /.
https://github.com/golang/go/blob/master/src/net/http/pattern.go#L137
i think multi means that this path can match a lot of paths. but / just match one.
which result in [this line] (https://github.com/golang/go/blob/master/src/net/http/pattern.go#L309) return overlaps.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 1:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from Jonathan Amsterdam:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!
Message from cong yin:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/621176. After addressing review feedback, remember to publish your drafts!