net
net copied to clipboard
golang
http2: add SETTINGS_ENABLE_CONNECT_PROTOCOL support
This PR (HEAD: d1683ac987d8545d9020f3f863e4885a30cadb7a) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Weidi Deng:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 1:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 77f622bf829dabf319b41a8fc8cf716436d33645) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: 4e0170fe1f5a5900d0df08ca5d33d29b02a6c4f0) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
This PR (HEAD: bccd6b93022767f96a70c960b7094791d8f79d8f) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Weidi Deng:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 5:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 4aac6770497d64ee256e1557eabb04f0b5c43fe4) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Weidi Deng:
Patch Set 5:
(5 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 6:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Weidi Deng:
Patch Set 6:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: cba5ecd7b7ecf842317301c425ef5107c54bc2ae) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/net/+/610977.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Damien Neil:
Patch Set 7: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 7:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-11-22T00:52:09Z","revision":"802423183e33825e36fc900ee7e99ef9c9d7cfbc"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 7: Auto-Submit+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 7: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 7:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 7: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Damien Neil:
Patch Set 7: Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!
Message from Roland Shoemaker:
Patch Set 7: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/610977. After addressing review feedback, remember to publish your drafts!