net
net copied to clipboard
golang
fix: if the only stream in a connection times out, prevent re-use
This commit mitigates some raciness which can occur when an established connection fails. Without it, the connection can continue to be drawn from the connection pool, leading to subsequent requests failing.
There may very well be a better way.
Details in https://github.com/golang/go/issues/59690
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR (HEAD: db3e8a7f6b46e537bbaf6b29080cad0d683d6c8a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/485715 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1:
(3 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 613c39d390d0672bb2e67c5d2266e07491e88582) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/485715 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Damien Neil:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: ab7b5a39c5def296519560559b05ed29d2b4c6d1) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/net/+/485715 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Ben Tasker:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. After addressing review feedback, remember to publish your drafts!
Message from Ben Tasker:
Patch Set 3:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. After addressing review feedback, remember to publish your drafts!
Message from Ben Tasker:
Patch Set 3:
(4 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/485715. After addressing review feedback, remember to publish your drafts!