net icon indicating copy to clipboard operation
net copied to clipboard

Published 20 hours ago • verified publisher icon golang

proxy: expand Dialer interface to expose DialContext

Open sjpotter opened this issue 2 years ago • 4 comments

currently, the Dialer interface returned (from say proxy.SOCKS5()) only exposes the Dial function, while it has a DialContext function as well. As Dial() usage is deprecated, DialContext should be exposed as well.

All implementations in proxy already had a DialContext function besides a single test recording struct, so added a similiar recorder to it.

sjpotter avatar Feb 06 '23 09:02 sjpotter

This PR (HEAD: 9178fd775914f6757c687b5a783a9b3aa86b04fb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/465495 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Feb 06 '23 10:02 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 07 '23 00:02 gopherbot

Message from Shaya Potter:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 07 '23 08:02 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/465495. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 07 '23 23:02 gopherbot