net icon indicating copy to clipboard operation
net copied to clipboard

html: add PrependChild and InsertAfter

Open olavfosse opened this issue 3 years ago • 11 comments

These methods complement the already existing AppendChild and InsertBefore methods in allowing for easy and safe manipulation of Node trees.

For example code like

oldChild.Parent.InsertBefore(newChild, oldChild.NextSibling)

can now be written like

oldChild.Parent.InsertAfter(newChild, oldChild)

and code like

node.InsertBefore(newNode, node.FirstChild)

can now be written like

node.PrependChild(newNode)

olavfosse avatar Jun 22 '21 08:06 olavfosse

This PR (HEAD: a14f476d4b3961f939d5509bdec0636892b10b8c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/329734 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Jun 22 '21 08:06 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 22 '21 08:06 gopherbot

Message from Damien Neil:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 28 '21 20:06 gopherbot

Message from Olav Fosse:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Jun 29 '21 06:06 gopherbot

Message from Damien Neil:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Olav Fosse:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 08 '21 11:11 gopherbot

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 09 '21 22:11 gopherbot

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 10 '21 17:11 google-cla[bot]

@googlebot I signed it!

olavfosse avatar Nov 10 '21 17:11 olavfosse

This PR (HEAD: f7e0d51d255c7971acb9ef9f7ebb4c8476ebecee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/329734 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Nov 10 '21 17:11 gopherbot

Message from Olav Fosse:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/329734. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Nov 10 '21 18:11 gopherbot