mobile icon indicating copy to clipboard operation
mobile copied to clipboard

Add ability to disable bitcode

Open jeanregisser opened this issue 5 years ago • 2 comments

Description

This PR adds a new DISABLE_BITCODE environment variable to be able to disable bitcode.

Why

Currently bitcode embedding is enabled by default for go >= 1.14 and there was no way to disable it.

In our celo-org/celo-blockchain project (written in Go) we currently need bitcode disabled because one of the dependencies is written in Rust and we've had compatibility issues with the Rust generated bitcode and recent version of Xcode.

We were good with go 1.13 (bitcode is disabled there), but we wanted to upgrade to go 1.14 and got the following error:

go build runtime/cgo: invalid flag in go:cgo_ldflag: -fembed-bitcode

See more in https://app.circleci.com/pipelines/github/celo-org/celo-blockchain/4999/workflows/9807228b-1b99-44f2-90f7-371bfeba9e97/jobs/46791

jeanregisser avatar Nov 27 '20 14:11 jeanregisser

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Nov 27 '20 14:11 google-cla[bot]

@jeanregisser could you try #70 and see if it still has the issue? ddd6497b067577b19dddcb2b88017887a0227eb5 enabled bitcode unconditionally, but I’m curious if this issue with Rust still exists.

ydnar avatar Sep 14 '21 03:09 ydnar

Dropping this, as bitcode is deprecated since Xcode 14.

jeanregisser avatar Oct 06 '23 14:10 jeanregisser