golang
Correctly find packages in module mode
I found that with modules enabled (and not using vendor) that this regexp would not pass when you think it should. The prefix with modules is just "_" which is also present in vendor mode... This change means it matches in both ways as expected.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
This PR (HEAD: b8c316dde1eaef013faea605eb7fcb6ed86aea36) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/mobile/+/227542 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
Added another change as it seems that the go package listing format changed from 1.12 to 1.13, now it supports both
This PR (HEAD: 157226355b146255fc54b77dc8227f8559d58b20) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/mobile/+/227542 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Hyang-Ah Hana Kim:
Patch Set 2: Run-TryBot+1
(1 comment)
Thank you for the contribution! Can you share some of the nm output you are observing?
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 2:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=b0c48dd0
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 2: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
I think I was testing against go version devel +8bbfc51d9a and I saw this output:
2020/05/13 12:32:00 001dc988 t _vendor/golang.org/x/text/unicode/norm.nextMultiNorm
(for example)
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 2:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=b0c48dd0
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 2: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/227542. After addressing review feedback, remember to publish your drafts!
I guess this is irrelevant now as the affected versions are not supported