image bmp: decode 1, 2 and 4 bits-per-pixel palettes

Specification: http://www.digicamsoft.com/bmp/bmp.html Fixes golang/go#29711 Fixes golang/go#58005

Dec 17 '24 06:12 tuyenpthust

This PR (HEAD: baf6a94a8c7e5dfc2ec10b25d4b8373c62cf92d7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/636975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Dec 17 '24 07:12 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Dec 17 '24 07:12 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Dec 17 '24 07:12 gopherbot

Message from Nigel Tao:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 04 '25 00:03 gopherbot

Message from Nigel Tao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 04 '25 00:03 gopherbot

This PR (HEAD: b482649d571a7d1de3c3c94c85bda5c7ef5fda18) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/636975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Mar 05 '25 16:03 gopherbot

This PR (HEAD: 9f758b290c2e2a09a7feb987920f49e23610b783) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/636975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Mar 05 '25 16:03 gopherbot

Message from Phan Thanh Tuyên:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 05 '25 17:03 gopherbot

Message from Nigel Tao:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 07 '25 06:03 gopherbot

This PR (HEAD: 1a0378eb556905c0437229f7f55e4d2718ab3a01) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/636975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Mar 07 '25 15:03 gopherbot

Message from Phan Thanh Tuyên:

Patch Set 5:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 07 '25 16:03 gopherbot

Message from Nigel Tao:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 24 '25 00:03 gopherbot

Message from Nigel Tao:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Mar 24 '25 00:03 gopherbot

This PR (HEAD: 12c6ab1cf21771e37bf76eb9a15d6b35a9aa8d3d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/image/+/636975.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Apr 01 '25 01:04 gopherbot

Message from Phan Thanh Tuyên:

Patch Set 7:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Apr 01 '25 01:04 gopherbot

Message from Nigel Tao:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Apr 01 '25 22:04 gopherbot

Message from Phan Thanh Tuyên:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Apr 02 '25 02:04 gopherbot

Message from Phan Thanh Tuyên:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Apr 24 '25 16:04 gopherbot

hi @nigeltao can you take another look on this? Thanks

Jun 27 '25 08:06 tuyenpthust

Message from Nigel Tao:

Patch Set 8: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Gopher Robot:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Nigel Tao:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Dmitri Shuralyov:

Patch Set 8: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-07-15T05:26:35Z","revision":"47c68b72727a5ac9d44df82d067c0e548861a89a"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Dmitri Shuralyov:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Dmitri Shuralyov:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/636975. After addressing review feedback, remember to publish your drafts!

Jul 15 '25 05:07 gopherbot

This PR is being closed because golang.org/cl/636975 has been merged.

Jul 22 '25 02:07 gopherbot