groupcache icon indicating copy to clipboard operation
groupcache copied to clipboard

allow basic logging for http Get err with RegisterErrLogFn

Open qbig opened this issue 7 years ago • 6 comments

attempt to improve this :

func (g *Group) load(ctx Context, key string, dest Sink) (value ByteView, destPopulated bool, err error) { // TODO(bradfitz): log the peer's error? keep // log of the past few for /groupcachez? It's // probably boring (normal task movement), so not // worth logging I imagine.

qbig avatar Apr 11 '17 10:04 qbig

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Apr 11 '17 10:04 googlebot

I signed it!

qbig avatar Apr 11 '17 15:04 qbig

CLAs look good, thanks!

googlebot avatar Apr 11 '17 15:04 googlebot

updated:)

qbig avatar Apr 12 '17 03:04 qbig

sorry.. but was there a new review? https://github.com/golang/groupcache/pull/81#pullrequestreview-32262402 didn't show anything

qbig avatar Apr 12 '17 11:04 qbig

@bradfitz any other parts I could improve on this diff ?

qbig avatar Apr 13 '17 07:04 qbig