groupcache
groupcache copied to clipboard
allow basic logging for http Get err with RegisterErrLogFn
attempt to improve this :
func (g *Group) load(ctx Context, key string, dest Sink) (value ByteView, destPopulated bool, err error) { // TODO(bradfitz): log the peer's error? keep // log of the past few for /groupcachez? It's // probably boring (normal task movement), so not // worth logging I imagine.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!
) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
I signed it!
CLAs look good, thanks!
updated:)
sorry.. but was there a new review? https://github.com/golang/groupcache/pull/81#pullrequestreview-32262402 didn't show anything
@bradfitz any other parts I could improve on this diff ?