go icon indicating copy to clipboard operation
go copied to clipboard

runtime: delete unused parameter of userForced

Open jianfengtony opened this issue 1 month ago • 15 comments

delete unused parameter userForced

jianfengtony avatar Dec 06 '25 16:12 jianfengtony

This PR (HEAD: 40077fae18f131095d20e3aa3e24c8871828ebd3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/727680.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Dec 06 '25 16:12 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 16:12 gopherbot

Message from Jorropo:

Patch Set 1: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 16:12 gopherbot

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-06T16:43:23Z","revision":"a996eaaf54dac75701816ccc1c1df162db10e478"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 17:12 gopherbot

Message from Jorropo:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 17:12 gopherbot

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64_avx512 has failed with summary (view all results):


To reproduce, try gomote repro 8696215752067303745.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 17:12 gopherbot

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 17:12 gopherbot

This PR (HEAD: 6a32c8ff6e63f8b149c0803e8b6636022bd9d066) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/727680.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Dec 07 '25 01:12 gopherbot

Message from Keith Randall:

Patch Set 2: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 07 '25 01:12 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-07T01:14:03Z","revision":"0c667d13d623c053333764d91a137f4ad2a7474f"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 07 '25 01:12 gopherbot

Message from Keith Randall:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 07 '25 01:12 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 07 '25 01:12 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 07 '25 01:12 gopherbot

Message from Tony Tang:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727680. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 07 '25 13:12 gopherbot