go icon indicating copy to clipboard operation
go copied to clipboard

net: fix some ineffectual assignments reported by ineffassign

Open linsite opened this issue 3 weeks ago • 34 comments

Updates #35136

linsite avatar Dec 05 '25 05:12 linsite

This PR (HEAD: b62df434e09adb85e5480bdcdc6ad985ad7d1287) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/727080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Dec 05 '25 05:12 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 05:12 gopherbot

Message from Lin Lin:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 05:12 gopherbot

Message from Jorropo:

Patch Set 1: Code-Review+2 Commit-Queue+1

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 07:12 gopherbot

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T06:54:13Z","revision":"19f8657aca936cd2e3921c3151c0436fdf72df5b"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 07:12 gopherbot

Message from Jorropo:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 07:12 gopherbot

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):


To reproduce, try gomote repro 8696343417028376241.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 07:12 gopherbot

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 07:12 gopherbot

This PR (HEAD: dc13df64a24c2903a8e88a88b6ca677616857f86) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/727080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Jorropo:

Patch Set 2: Code-Review+2 Commit-Queue+1

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T09:03:27Z","revision":"6c673cfb766c28bdfcb9d987478077a230df186b"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Jorropo:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):


To reproduce, try gomote repro 8696335285524338097.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Lin Lin:

Patch Set 2:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Jorropo:

Patch Set 2: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T09:18:51Z","revision":"6c673cfb766c28bdfcb9d987478077a230df186b"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Jorropo:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):


To reproduce, try gomote repro 8696334317640969233.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Jorropo:

Patch Set 2: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-05T09:37:21Z","revision":"6c673cfb766c28bdfcb9d987478077a230df186b"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Jorropo:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):


To reproduce, try gomote repro 8696333152779955265.

Additional links for debugging:


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 09:12 gopherbot

Message from Florian Lehner:

Patch Set 2: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 05 '25 18:12 gopherbot

This PR (HEAD: 6db1a88da60fce3e4fd6697d5db75d55d53b2b49) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/727080.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Dec 06 '25 00:12 gopherbot

Message from Lin Lin:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 01:12 gopherbot

Message from Jorropo:

Patch Set 4: Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 01:12 gopherbot

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-12-06T01:31:55Z","revision":"a701730c5f5bd4da89660fd4d511dc1a4d3ebdee"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 01:12 gopherbot

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 01:12 gopherbot

Message from Jorropo:

Patch Set 5: Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/727080. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Dec 06 '25 05:12 gopherbot