go icon indicating copy to clipboard operation
go copied to clipboard

runtime: add the checkPtraceScope to skip certain tests

Open fuowang opened this issue 1 year ago • 2 comments

When the kernel parameter ptrace_scope is set to 2 or 3, certain test cases in runtime-gdb_test.go will fail. We should skip these tests.

Fixes #69932

fuowang avatar Oct 18 '24 08:10 fuowang

This PR (HEAD: 8b99f1a2f7ca126a6d7a31ddc326ece2af715f36) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 18 '24 08:10 gopherbot

Message from qiu laidongfeng2:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 18 '24 16:10 gopherbot

This PR (HEAD: 495f91f68a64d7cffe023d208755a0786cc2d80c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from Fuo Wang:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from qiu laidongfeng2:

Patch Set 2: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-20T12:22:00Z","revision":"d961e93a05f9ea4f5fc79c0edc7d61b7c5fb3546"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from qiu laidongfeng2:

Patch Set 2: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 20 '24 12:10 gopherbot

Message from Michael Knyszek:

Patch Set 2:

(6 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 21 '24 14:10 gopherbot

This PR (HEAD: 70857cf22341a92a16dda7fe1c313cba74d500a7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 22 '24 11:10 gopherbot

Message from Fuo Wang:

Patch Set 3:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 11:10 gopherbot

Message from qiu laidongfeng2:

Patch Set 3: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-22T12:17:55Z","revision":"ad256d2edfd39528835ad23e16e34438a5a7811e"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 12:10 gopherbot

Message from qiu laidongfeng2:

Patch Set 3: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 3:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 12:10 gopherbot

Message from Michael Knyszek:

Patch Set 3: Code-Review+2

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 17:10 gopherbot

This PR (HEAD: 063759e04cfc5ea750ed1d381d8586134488a96b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 23 '24 01:10 gopherbot

Message from Fuo Wang:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '24 02:10 gopherbot

Message from Michael Knyszek:

Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '24 15:10 gopherbot

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-23T15:11:20Z","revision":"7a38e13f3074ec61a1bcfa3cd057a842eb49aebc"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '24 15:10 gopherbot

Message from Michael Knyszek:

Patch Set 4: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '24 15:10 gopherbot

Message from Go LUCI:

Patch Set 4:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '24 15:10 gopherbot

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 23 '24 15:10 gopherbot

This PR is being closed because golang.org/cl/620857 has been merged.

gopherbot avatar Oct 23 '24 17:10 gopherbot