go icon indicating copy to clipboard operation
go copied to clipboard

internal/runtime/atomic: add Xchg8 for arm

Open mauri870 opened this issue 1 year ago • 14 comments

For #69735

Cq-Include-Trybots: luci.golang.try:gotip-linux-arm

mauri870 avatar Oct 17 '24 13:10 mauri870

This PR (HEAD: f40594758f1d976e2478dbb10e1921c27fc2f5c1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 17 '24 13:10 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 13:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 14:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 1: Commit-Queue+1 Run-TryBot+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 17:10 gopherbot

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-17T17:45:46Z","revision":"437e6df6835f46f70c734eca19e6f83ec09fd40a"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 17:10 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 18:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 18:10 gopherbot

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 18:10 gopherbot

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 17 '24 18:10 gopherbot

Message from Keith Randall:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 18 '24 02:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 18 '24 11:10 gopherbot

Message from Keith Randall:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 18 '24 12:10 gopherbot

Message from Dmitri Shuralyov:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 18 '24 16:10 gopherbot

Message from Rhys Hiltner:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 18 '24 18:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 21 '24 12:10 gopherbot

This PR (HEAD: 0445d055a802c410e6767da3d95ab9e378f71c91) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 21 '24 16:10 gopherbot

Message from Keith Randall:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 21 '24 20:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 14:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 14:10 gopherbot

Message from Keith Randall:

Patch Set 4:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 22 '24 15:10 gopherbot

This PR (HEAD: ef1cbdcea443f2b285cbb3346612df85dd644b1f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620855.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Oct 24 '24 00:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 6: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 11:10 gopherbot

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-10-24T11:43:41Z","revision":"69820e66ef4c7f4798b1791ab0d4f400e0a723a1"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 11:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 11:10 gopherbot

Message from Mauri de Souza Meneguzzo:

Patch Set 6: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 6:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 12:10 gopherbot

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 12:10 gopherbot

Message from Keith Randall:

Patch Set 6: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 17:10 gopherbot

Message from Keith Randall:

Patch Set 6: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 24 '24 17:10 gopherbot

Message from Michael Pratt:

Patch Set 6: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/620855. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Oct 28 '24 15:10 gopherbot