go icon indicating copy to clipboard operation
go copied to clipboard

x/pkgsite: searches for standard library packages should surface and prioritize v2 versions

Open cespare opened this issue 1 year ago • 4 comments

What is the URL of the page with the issue?

https://pkg.go.dev/search?q=rand

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/127.0.0.0 Safari/537.36

Screenshot

screen_20240801232855

What did you do?

I searched for "rand".

What did you see happen?

The top search results were the standard library's math/rand and crypto/rand packages. The math/rand/v2 package, which is what I mean by "rand" in most new code I write today, does not appear in the list of search results. The only indication of math/rand/v2 is some small, easy-to-miss text below the math/rand search result which says:

Related packages in the standard library: math/rand/v2

What did you expect to see?

I think that if I search for "rand", math/rand/v2 ought to be very highly ranked in the search results; ideally, it would appear above math/rand. v2 is what people ought to be using for new code and we should nudge people in that direction. In any case, it should certainly appear near the top of the list.

I think this is just a case where pkgsite isn't keeping up with the v2 evolution happening in the standard library. As we get more v2 packages, the issue will get worse.

This is essentially the standard library equivalent of an issue I filed for third-party modules a few years back: #36969.

There's also a related, thornier issue: if I search for "math/rand", it takes me directly to https://pkg.go.dev/math/rand -- perhaps that ought to go to a search result page now that includes math/rand and math/rand/v2.

cespare avatar Aug 02 '24 06:08 cespare

#66452 is the "related, thornier" issue I mentioned at the end.

cespare avatar Aug 02 '24 06:08 cespare

cc @jba

hyangah avatar Aug 08 '24 12:08 hyangah

Not sure if this should be a separate issue about the major version banner...

When I search for, e.g. GitHub, I clearly see that there is a new major version:

Image Image

If I ended up on https://pkg.go.dev/math/rand, there is no indication of v2 at the top.

Image

Only at the very end there is mention of v2 directory:

Image

alexbozhenko avatar Dec 09 '25 02:12 alexbozhenko