go icon indicating copy to clipboard operation
go copied to clipboard

x/build: add LUCI illumos-amd64 builder

Open dmitshur opened this issue 1 year ago • 2 comments

There currently isn't a LUCI builder that tests the illumos/amd64 port (other than the misc-compile builder, which tests only that the port compiles). This is the tracking issue for it.

The next steps that a builder owner will need to follow to make progress here are documented https://go.dev/wiki/DashboardBuilders#luci-builders.

dmitshur avatar May 10 '24 20:05 dmitshur

G'day! I am creating the new builder with hostname illumos-amd64-jclulow.

The CSR is attached: illumos-amd64-jclulow.csr.txt

Please, Mr. Music, will you play?

jclulow avatar May 16 '24 19:05 jclulow

Thank you for starting to work on this builder. Here's the certificate: illumos-amd64-jclulow-1715889249.cert.txt.

Edit: I'll also note that if the previous coordinator-based builder starts to get in the way of you bringing up the new LUCI builder, you should feel free to stop the previous builder and focus on the new one. It's certainly fine to keep the old one running if it doesn't get in the way. Thanks.

dmitshur avatar May 16 '24 19:05 dmitshur

I put the new one in a new VM, so they don't interact. The host is definitely getting LUCI tokens, and the swarm thing is definitely doing something inscrutable and then rebooting the instance every now and again.

I had a peek in some logs, and I think it's a bit confused about the platform: it says "solaris-amd64" in a bunch of log messages, which is obviously not quite right, it should be "illumos-amd64" presumably.

Please let me know what to do next!

jclulow avatar May 17 '24 04:05 jclulow

Thanks for getting to this point.

The bot is visible at https://chromium-swarm.appspot.com/bot?id=illumos-amd64-jclulow. As you noted, it's identifying itself as having a cipd_platform value of "solaris-amd64", but we indeed need it to be "illumos-amd64" in order to match the builder definition at https://ci.chromium.org/ui/p/golang/builders/ci/gotip-illumos-amd64.

I suggest stopping this builder for now to avoid it providing noise for the https://ci.chromium.org/ui/p/golang/builders/ci/gotip-solaris-amd64 builder.

The next steps here will be to make a change in the swarming bot code to report its OS as illumos rather than solaris. The relevant code is here:

https://source.chromium.org/chromium/infra/infra/+/main:luci/appengine/swarming/swarming_bot/api/os_utilities.py;l=291-301;drc=4b5b630058c9a41d6ddcb7cef61630b434eeccb0

I suggest taking a look at a previous example of a similar change being done in https://github.com/golang/go/issues/64660#issuecomment-1852896973.

dmitshur avatar May 17 '24 04:05 dmitshur