go os/exec: fix manually set Cmd.Path run fail without suffix

#36768 need CL 512155,but see #62596 my CL turns the Windows-only race into a race for all machines. For avoid data race for cmd.Path, in CL 527820 fixed data race, but cause manually set Cmd.Path run fail without suffix, use record whether lookExtensions have been called in Command fix issue. For Cmd.Start, cannot write the result of calling lookExtensions back to Cmd.Path because that would result in a data race.

Fixes #66586

Apr 25 '24 12:04 qiulaidongfeng

This PR (HEAD: 78e0ae522804cc51b4912423cb11dcaa27bd2aa7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Apr 25 '24 12:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 12:04 gopherbot

This PR (HEAD: fd6c529a7aa8795e1819112c2b64714b9ff23676) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Apr 25 '24 12:04 gopherbot

Message from qiulaidongfeng:

Patch Set 2: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-25T12:47:06Z","revision":"513c94fb4669854608794164d65687b1d6b0a07e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from qiulaidongfeng:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 581695)
tools on master (commit b00d49e)

Error: failed to run "make.bash": exit status 2

Links:

"make.bash" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from qiulaidongfeng:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-25T13:00:46Z","revision":"74f07c1f2dca4e87e05e2c846a5721c2efc0986b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from qiulaidongfeng:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 4:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-amd64 has failed with summary (view all results):

FAILURE

go on master (change 581695)

Error: shard 1: failed to run "make.bat": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

This PR (HEAD: be41db8f0ec3c242d349d0704a225543d32adb71) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Apr 25 '24 13:04 gopherbot

Message from qiulaidongfeng:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-25T13:27:31Z","revision":"809075a3c45077dda6dc4d9fecc402dbec7fecff"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 13:04 gopherbot

Message from qiulaidongfeng:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 14:04 gopherbot

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 14:04 gopherbot

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 14:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 20:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 25 '24 20:04 gopherbot

This PR (HEAD: d9ffb2df8119a3159bdd5e98ab5f03f9d9c6e259) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/581695.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Apr 26 '24 08:04 gopherbot

Message from qiulaidongfeng:

Patch Set 6: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 26 '24 08:04 gopherbot

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-26T08:22:57Z","revision":"d21a94e2cfa4adb969a93ad9900d863e5a40e629"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 26 '24 08:04 gopherbot

Message from qiulaidongfeng:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 26 '24 08:04 gopherbot

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 26 '24 08:04 gopherbot

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 26 '24 08:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 28 '24 01:04 gopherbot

Message from qiulaidongfeng:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 28 '24 01:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/581695. After addressing review feedback, remember to publish your drafts!

Apr 28 '24 01:04 gopherbot