go icon indicating copy to clipboard operation
go copied to clipboard

reflect: add iterative related methods

Open qiulaidongfeng opened this issue 1 year ago • 59 comments

Fixes #66056

qiulaidongfeng avatar Apr 14 '24 12:04 qiulaidongfeng

This PR (HEAD: 022384e282973d74d83677adc6330d8df221ddc4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 14 '24 13:04 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 14 '24 13:04 gopherbot

This PR (HEAD: 45059cff5566c1340bdd038e35257e056714c69f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 14 '24 13:04 gopherbot

This PR (HEAD: 8a67f5601b20dc8fd3ad521407b22f1c2bc936fd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 15 '24 12:04 gopherbot

This PR (HEAD: 35cf5531dab3ff7a03485a7fa10b2876b8b44255) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 15 '24 12:04 gopherbot

This PR (HEAD: db63305d7fb4b9b59fd7522dc2bdf8e2ec6e96e1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 15 '24 12:04 gopherbot

Message from qiulaidongfeng:

Patch Set 5:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 15 '24 12:04 gopherbot

Message from jimmy frasche:

Patch Set 5:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 15 '24 17:04 gopherbot

This PR (HEAD: e1b6464b9e79c820c25fc3cf956b56dbe8777e1a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from qiulaidongfeng:

Patch Set 6: Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-16T12:20:57Z","revision":"7e325b3a9d301f9045a077fda15e4c08a15cc703"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from qiulaidongfeng:

Patch Set 6: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):


FAILURE

Error: shard 1: failed to run "make.bash": exit status 2

Links:


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from qiulaidongfeng:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 16 '24 12:04 gopherbot

Message from Frederik Zipp:

Patch Set 6:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 24 '24 19:04 gopherbot

Message from Carlana Johnson:

Patch Set 6:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 24 '24 22:04 gopherbot

This PR (HEAD: bfa04a40b8be5723155e0f0491aad7e4a27a22ec) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 25 '24 11:04 gopherbot

Message from qiulaidongfeng:

Patch Set 7:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 25 '24 11:04 gopherbot

Message from Frederik Zipp:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 25 '24 12:04 gopherbot

Message from qiulaidongfeng:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 25 '24 12:04 gopherbot

Message from Frederik Zipp:

Patch Set 7:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 25 '24 14:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 7:

(10 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 25 '24 20:04 gopherbot

This PR (HEAD: d6d01315c68365736d37e3613b27b6ff130a6245) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578815.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Apr 26 '24 09:04 gopherbot

Message from qiulaidongfeng:

Patch Set 8:

(10 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 26 '24 09:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 8: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '24 01:04 gopherbot

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-28T01:10:44Z","revision":"be738a97a550cdfe6edf520b9920db0c6aa74ea4"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '24 01:04 gopherbot

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '24 01:04 gopherbot

Message from Go LUCI:

Patch Set 8:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):


FAILURE

Error: shard 1: failed to run "make.bash": exit status 2

Links:


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '24 01:04 gopherbot

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result-1


Please don’t reply on this GitHub thread. Visit golang.org/cl/578815. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 28 '24 01:04 gopherbot