golang
crypto/subtle: use min builtin function in XORBytes
This PR (HEAD: b8a6a58358ff893f678939ebd4ab641bbf8f7561) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564577.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 1: Commit-Queue+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-02-16T10:00:07Z","revision":"a2904bf7bfa6c3690635a45e37d7165980fb174b"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 1: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 1: LUCI-TryBot-Result-1
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 31421d066833f721f3fa261ac9dc49724fffb5f8) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564577.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from qiulaidongfeng:
Patch Set 2: Commit-Queue+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
Dry run: CV is trying the patch.
Bot data: {"action":"start","triggered_at":"2024-02-16T10:25:31Z","revision":"4c873bb1055b6799e2435631f2503c70bbea9cf5"}
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from qiulaidongfeng:
Patch Set 2: -Commit-Queue
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2:
This CL has passed the run
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Go LUCI:
Patch Set 2: LUCI-TryBot-Result+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Filippo Valsorda:
Patch Set 2: Auto-Submit+1 Code-Review+2
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!
Message from Than McIntosh:
Patch Set 2: Code-Review+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/564577. After addressing review feedback, remember to publish your drafts!