go icon indicating copy to clipboard operation
go copied to clipboard

hash/maphash: parallel run test

Open qiulaidongfeng opened this issue 1 year ago • 7 comments

This reduces the go test hash/maphash time by more than half.

qiulaidongfeng avatar Feb 16 '24 01:02 qiulaidongfeng

This PR (HEAD: 440c35f8b544a16cc733e3291f963f738dd59a47) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564576.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Feb 16 '24 01:02 gopherbot

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 01:02 gopherbot

Message from qiulaidongfeng:

Patch Set 1: Commit-Queue+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 02:02 gopherbot

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-16T01:53:32Z","revision":"7f3ae7036b2863bfea0a149abc600c4099c644d9"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 02:02 gopherbot

Message from qiulaidongfeng:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 02:02 gopherbot

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 02:02 gopherbot

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 02:02 gopherbot

Message from Keith Randall:

Patch Set 1: Auto-Submit+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 17:02 gopherbot

Message from Keith Randall:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 17:02 gopherbot

Message from Keith Randall:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 17:02 gopherbot

Message from qiulaidongfeng:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564576. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 17 '24 04:02 gopherbot

This PR is being closed because golang.org/cl/564576 has been merged.

gopherbot avatar Feb 20 '24 15:02 gopherbot