go icon indicating copy to clipboard operation
go copied to clipboard

net/http: support TCP half-close when HTTP is upgraded in ReverseProxy

Open callthingsoff opened this issue 1 year ago • 7 comments

Rather than closing all sockets immediately when the one side gets an EOF, this CL closes the write stream on the socket to inform the transfer is finished.

Fixes #35892

callthingsoff avatar Feb 15 '24 13:02 callthingsoff

This PR (HEAD: a715b09ade3d470566aee0beb6b82e746d7e18f7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/564375.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot avatar Feb 15 '24 13:02 gopherbot

Message from Jes Cok:

Patch Set 1: Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 15 '24 13:02 gopherbot

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-02-15T13:46:56Z","revision":"17f250ed43bdc737df15effb17afe1b696e5352d"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 15 '24 13:02 gopherbot

Message from Jes Cok:

Patch Set 1: -Commit-Queue


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 15 '24 14:02 gopherbot

Message from Go LUCI:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 15 '24 14:02 gopherbot

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 15 '24 14:02 gopherbot

Message from Jes Cok:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 15 '24 23:02 gopherbot

Message from Jes Cok:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 16 '24 23:02 gopherbot

Message from Jes Cok:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 19 '24 15:02 gopherbot

Message from Jes Cok:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/564375. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Feb 21 '24 17:02 gopherbot