go icon indicating copy to clipboard operation
go copied to clipboard

net/http: TestTransportClosesBodyOnError failures

Open gopherbot opened this issue 2 years ago • 4 comments

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportClosesBodyOnError"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportClosesBodyOnError (0.00s)
    --- FAIL: TestTransportClosesBodyOnError/h1 (10.24s)
        transport_test.go:3709: timeout waiting for server handler to complete

watchflakes

gopherbot avatar Jan 25 '23 16:01 gopherbot

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportClosesBodyOnError"
2023-01-17 19:53 darwin-amd64-10_15 go@3af3810a net/http.TestTransportClosesBodyOnError (log)
--- FAIL: TestTransportClosesBodyOnError (0.00s)
    --- FAIL: TestTransportClosesBodyOnError/h1 (10.24s)
        transport_test.go:3709: timeout waiting for server handler to complete

watchflakes

gopherbot avatar Jan 25 '23 16:01 gopherbot

(attn @neild)

bcmills avatar Jan 25 '23 16:01 bcmills

Change https://go.dev/cl/463222 mentions this issue: net/http: remove five second timeout from TestTransportClosesBodyOnError

gopherbot avatar Jan 26 '23 21:01 gopherbot

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportClosesBodyOnError"
2023-02-01 19:47 linux-amd64-race go@ab0f0459 net/http.TestTransportClosesBodyOnError (log)
--- FAIL: TestTransportClosesBodyOnError (0.00s)

watchflakes

gopherbot avatar Feb 02 '23 19:02 gopherbot

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportClosesBodyOnError"
2023-02-06 13:49 darwin-amd64-race go@bf8d142b net/http.TestTransportClosesBodyOnError (log)
--- FAIL: TestTransportClosesBodyOnError (0.00s)
    --- FAIL: TestTransportClosesBodyOnError/h2 (0.20s)
        testing.go:1446: race detected during execution of test
    --- FAIL: TestTransportClosesBodyOnError/h1 (0.27s)
        testing.go:1446: race detected during execution of test

watchflakes

gopherbot avatar Feb 06 '23 23:02 gopherbot

The last two watchflakes posts are #58168. Updated the pattern to exclude it.

bcmills avatar Feb 07 '23 14:02 bcmills