go icon indicating copy to clipboard operation
go copied to clipboard

cmd/compile: the loong64 intrinsic for CompareAndSwapUint32 function needs to sign extend its "old" argument. [1.18 backport]

Open gopherbot opened this issue 3 years ago • 5 comments

@dr2chase requested issue #57282 to be considered for backport to the next 1.18 minor release.

@gopherbot please open backport issues.

gopherbot avatar Dec 15 '22 20:12 gopherbot

Loong64 isn't supported by 1.18, so not a bug.

dr2chase avatar Dec 15 '22 20:12 dr2chase

The three bugs/CLs were collapsed into one, and this is the one. Therefore it is the backport, though loong64 code won't be included in the 1.18 backport CL.

dr2chase avatar Dec 17 '22 01:12 dr2chase

Hi, what should we (loong64 porters) do at this point regarding this backport issue? Do we have to submit the backport CL now (or relatively quickly), or are you just planning to triage and decide on this later?

xen0n avatar Dec 17 '22 06:12 xen0n

Hi, I'll get it this time (and sorry for the late reply; I was traveling, then the weekend.) Thank you for checking, though.

dr2chase avatar Dec 19 '22 16:12 dr2chase

Change https://go.dev/cl/458357 mentions this issue: [release-branch.go1.18] cmd/compile: sign-extend the 2nd argument of the LoweredAtomicCas32 on mips64x,riscv64

gopherbot avatar Dec 19 '22 17:12 gopherbot

Closed by merging commit eeaf508d13b463c0bd2224275e239c01e06f4ade (CL 458357) to release-branch.go1.18.

dmitshur avatar Dec 28 '22 22:12 dmitshur