x/tools/gopls/internal/regtest/diagnostics: TestManuallyCreatingXTest failures

[gopherbot]

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/diagnostics" && test == "TestManuallyCreatingXTest"

Bug automatically created to collect these failures.

Example log:

panic: test timed out after 10m0s

testing.(*T).Run(0xc007a74820, {0x1ab9e02?, 0x0?}, 0xc00218e370)
	/Users/gopher/workdir/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/internal/lsp/regtest.(*Runner).Run(0xc0003723c0, 0xc007a74820, {0x1b1e4f0, 0xd6}, 0x1c28e38, {0x0, 0x0, 0xc004242760?})
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/runner.go:268 +0x3e5
golang.org/x/tools/internal/lsp/regtest.Run(...)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest(0x168cd47?)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/diagnostics/diagnostics_test.go:806 +0x5b
testing.tRunner(0xc007a74820, 0x1c28e40)

— watchflakes

[gopherbot]

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/diagnostics" && test == "TestManuallyCreatingXTest"

2022-08-05 17:04 darwin-amd64-11_0 tools@06d96ee8 go@0f6ee42f golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest (log)

panic: test timed out after 10m0s

testing.(*T).Run(0xc007a74820, {0x1ab9e02?, 0x0?}, 0xc00218e370)
	/Users/gopher/workdir/go/src/testing/testing.go:1494 +0x37a
golang.org/x/tools/internal/lsp/regtest.(*Runner).Run(0xc0003723c0, 0xc007a74820, {0x1b1e4f0, 0xd6}, 0x1c28e38, {0x0, 0x0, 0xc004242760?})
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/runner.go:268 +0x3e5
golang.org/x/tools/internal/lsp/regtest.Run(...)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest(0x168cd47?)
	/Users/gopher/workdir/gopath/src/golang.org/x/tools/gopls/internal/regtest/diagnostics/diagnostics_test.go:806 +0x5b
testing.tRunner(0xc007a74820, 0x1c28e40)

2022-09-02 00:49 darwin-arm64-12 tools@33c1ddd5 go@8e359106 golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest (log)

panic: test timed out after 10m0s

testing.(*T).Run(0x14002bf29c0, {0x10281022b?, 0x0?}, 0x14006946320)
	/tmp/buildlet/go/src/testing/testing.go:1527 +0x314
golang.org/x/tools/internal/lsp/regtest.(*Runner).Run(0x140005052c0, 0x14002bf29c0, {0x10287508c, 0xd6}, 0x102c65618, {0x0, 0x0, 0x63119337?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/lsp/regtest/runner.go:268 +0x394
golang.org/x/tools/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest(0x1400670e4e0?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/diagnostics/diagnostics_test.go:806 +0x68
testing.tRunner(0x14002bf29c0, 0x102c65620)

2022-09-07 16:01 darwin-arm64-12 tools@dd1bab2d go@3e758593 golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest (log)

panic: test timed out after 10m0s

testing.(*T).Run(0x14007122d00, {0x104f1b7db?, 0x0?}, 0x14002699220)
	/tmp/buildlet/go/src/testing/testing.go:1527 +0x314
golang.org/x/tools/internal/lsp/regtest.(*Runner).Run(0x14000245e00, 0x14007122d00, {0x104f8076b, 0xd6}, 0x105329e18, {0x0, 0x0, 0x6318cee4?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/lsp/regtest/runner.go:268 +0x394
golang.org/x/tools/internal/lsp/regtest.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/internal/lsp/regtest/regtest.go:54
golang.org/x/tools/gopls/internal/regtest/diagnostics.TestManuallyCreatingXTest(0x14006cccd00?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/regtest/diagnostics/diagnostics_test.go:806 +0x68
testing.tRunner(0x14007122d00, 0x105329e20)

— watchflakes

[adonovan]

This looks like another case of go command stuckness on Darwin; see #63937.