go icon indicating copy to clipboard operation
go copied to clipboard

runtime: cleanup timer codes

Open OmidHekayati opened this issue 2 years ago • 4 comments

The existing implementation has a poor structure and is a mess. I just moved exist codes to seprated files and structures to improve code and logic readability. No logic has been changed in this cleanup.

Updates #53953

OmidHekayati avatar Aug 05 '22 09:08 OmidHekayati

This PR (HEAD: c324f92761ffa53e2abdcb05a90b62ab9f7d88be) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/421615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Aug 05 '22 09:08 gopherbot

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/421615. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 05 '22 09:08 gopherbot

Message from Michael Knyszek:

Patch Set 1:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/421615. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 05 '22 16:08 gopherbot

Message from Omid Hekayati:

Patch Set 1:

(5 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/421615. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 06 '22 08:08 gopherbot

This PR (HEAD: 127edfded6530c438977d1649ce142d5477f4dbd) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/421615 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Aug 13 '22 12:08 gopherbot

Message from Omid Hekayati:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/421615. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Aug 15 '22 15:08 gopherbot