geo icon indicating copy to clipboard operation
geo copied to clipboard

Published 20 hours ago • verified publisher icon golang

Fix floating point failures seen on ppc64le

Open prashantkhoje opened this issue 2 years ago • 5 comments

Fixes test failures: - TestClosestEdgeQueryTrueDistanceLessThanChordAngleDistance (#88) - TestPointMeasuresPointArea (#87) - TestPredicatesRobustSignEqualities (#86)

prashantkhoje avatar Jun 14 '22 04:06 prashantkhoje

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jun 14 '22 04:06 google-cla[bot]

@rsned, @dsymonds, Who can help to review this pull request?

Thank you, Prashant

prashantkhoje avatar Jun 29 '22 14:06 prashantkhoje

Do you get any errors in matrix3x3_test when using PPC?

rsned avatar Jul 19 '22 21:07 rsned

No, i don't get any errors in matrix3x3_test on PPC.

prashantkhoje avatar Jul 20 '22 06:07 prashantkhoje

@ambujkumar3 fyi

prashantkhoje avatar Aug 26 '22 05:08 prashantkhoje

Fixed with commit https://github.com/golang/geo/commit/eee77999540a2fdb7ae874772c14223ee75e6739

rsned avatar Apr 21 '23 00:04 rsned