geo icon indicating copy to clipboard operation
geo copied to clipboard

Published 20 hours ago • verified publisher icon golang

RegionTermIndexer: Port from C++

Open sreekanth-cb opened this issue 6 months ago • 3 comments

Attempt to port a functional version of S2RegionTermIndexer

sreekanth-cb avatar May 14 '25 03:05 sreekanth-cb

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar May 14 '25 03:05 google-cla[bot]

There are lint errors: https://github.com/golang/geo/actions/runs/15011742506/job/42186000244?pr=178#step:4:34

jmr avatar May 14 '25 11:05 jmr

It looks like this is a copy of https://github.com/blevesearch/geo/commits/master/s2/region_term_indexer.go [helping to resolve #134] but you wrote that anyway, then changed email addresses. It would save time to provide a bit more background in the PR.

jmr avatar May 14 '25 12:05 jmr