gddo icon indicating copy to clipboard operation
gddo copied to clipboard

gosrc: svg files in presentations not displayed properly

Open mmcloughlin opened this issue 7 years ago • 3 comments

svg images are not displayed properly on talks.godoc.org, for example:

https://talks.godoc.org/github.com/golang/gddo/gosrc/testdata/sample.slide#5

svg images are repointed at https://rawgit.com/

https://github.com/golang/gddo/blob/9d8ff1c67be5c2da6321c656913e1fe355991138/gosrc/github.go#L245

According to their website "RawGit has reached the end of its useful life", hence the request is returning with a 403.

This is a simple fix if we can find another service for serving up the files.

mmcloughlin avatar Oct 10 '18 00:10 mmcloughlin

Some alternatives:

https://raw.githack.com/golang/gddo/master/gosrc/testdata/gopher.svg https://gitcdn.link/repo/golang/gddo/master/gosrc/testdata/gopher.svg

mmcloughlin avatar Oct 10 '18 03:10 mmcloughlin

See https://go-review.googlesource.com/c/gddo/+/140918

Aside, why is gobot not enabled for this repo, to automatically link issues with CLs?

mmcloughlin avatar Oct 10 '18 04:10 mmcloughlin

Aside, why is gobot not enabled for this repo, to automatically link issues with CLs?

Right now, only CLs that mention issues in the main Go issue tracker are enabled. See here. Please open an issue in the main tracker if you think we should change that.

dmitshur avatar Oct 13 '18 02:10 dmitshur