exp icon indicating copy to clipboard operation
exp copied to clipboard

rand: add methods to allow greater control over `PCGSource`

Open DeedleFake opened this issue 3 years ago • 8 comments

For golang/go#49934.

Add two methods to PCGSource, Seed128 and State.

The standard Seed method only allows seeding with a uint64, but the PCG internal state is, effectively, a uint128. Seed128 allows the user to pass both the high and low bits for this state as two uint64s, allowing much greater control over the generator's state.

State does the opposite, returning the entire 128-bit state as two uint64s.

DeedleFake avatar Apr 05 '22 03:04 DeedleFake

Should that be Seed128() instead? It's allowing you to set 128 bits of the generator's state, not 64.

DeedleFake avatar Apr 05 '22 03:04 DeedleFake

This PR (HEAD: 20a3031ddeef3b057cd935d145c5aaa3a7030d3c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/398354 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 05 '22 03:04 gopherbot

Message from Rob Pike:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/398354. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 05 '22 20:04 gopherbot

This PR (HEAD: 776a471211c5c0ec1a7d4bc4ebbd607f9cda5a2e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/398354 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 06 '22 14:04 gopherbot

Message from Rob Pike:

Patch Set 3: Code-Review+2

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/398354. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 17 '22 00:04 gopherbot

Message from Rob Pike:

Patch Set 3: -Code-Review

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/398354. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Apr 17 '22 00:04 gopherbot

This PR (HEAD: 7f2d9084acbfd75201d16a951289c37ae33987b8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/398354 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Apr 18 '22 15:04 gopherbot

Message from Rob Pike:

Patch Set 4: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/398354. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Sep 30 '22 00:09 gopherbot