exp icon indicating copy to clipboard operation
exp copied to clipboard

Added a needed feature to winfsnotify

Open b0bh00d opened this issue 4 years ago • 3 comments

The package lacks the ability to watch an entire tree for changes. To address that, I added a Boolean to the system, and the AddDeepWatch() and DeepWatch() functions to enable the 'bWatchSubtree' parameter of ReadDirectoryChanges() with this Boolean. This will allow the watch to report events anywhere within the watched folder tree.

The original functions, AddWatch() and Watch(), continue to behave shallow as they did before--only watching the specified folder--so existing code will not be impacted.

b0bh00d avatar Mar 03 '21 03:03 b0bh00d

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Mar 03 '21 03:03 google-cla[bot]

This PR (HEAD: 1305fe561f77c056d8f2d30112c0913c4f350430) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/exp/+/298249 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot avatar Mar 03 '21 14:03 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.


Please don’t reply on this GitHub thread. Visit golang.org/cl/298249. After addressing review feedback, remember to publish your drafts!

gopherbot avatar Mar 03 '21 14:03 gopherbot