golang
x/crypto: increasing the default BCrypt cost
Looking at git blame, it appears the DefaultCost for the Bcrypt library has remained unchanged for the past 14 years.
To keep up with modern hardware, I propose upgrading the Bcrypt library's DefaultCost from 10 to 12 to match the PHP 8.4 recent update in 2024.
Please see PHP's RFC for research on this topic, but please keep in mind the benchmarks are specific to PHP: https://wiki.php.net/rfc/bcrypt_cost_2023
This PR (HEAD: aa23a5e616d89d76aaf382947131a00739728bc1) has been imported to Gerrit for code review.
Please visit Gerrit at https://go-review.googlesource.com/c/crypto/+/710876.
Important tips:
- Don't comment on this PR. All discussion takes place in Gerrit.
- You need a Gmail or other Google account to log in to Gerrit.
- To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
- The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
- See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.
Message from Gopher Robot:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. After addressing review feedback, remember to publish your drafts!
Message from Gopher Robot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: A maintainer will review your change and provide feedback. See https://go.dev/doc/contribute#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11 or adds a tag like "wait-release", it means that this CL will be reviewed as part of the next development cycle. See https://go.dev/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. After addressing review feedback, remember to publish your drafts!
Message from Sean Liao:
Patch Set 2: Hold+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. After addressing review feedback, remember to publish your drafts!
Message from N:
Patch Set 2:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/710876. After addressing review feedback, remember to publish your drafts!