crypto
crypto copied to clipboard
golang
crypto/ocsp: Add Raw field to ocsp.Response
The Raw field contains the DER encoded repreentation of the OCSP response
This PR (HEAD: bdf47ae1ea674d549387da5a58dcd21c1045de99) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 7b4e24e587239af689a0a79766fd8385b4038fa3) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 9ac6681110cbbaa89df6085ee7aec80a0dfdfcea) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: f888226ed71dce8dedb694f2dd1837079adc59e6) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 18876f6fff05317523baffbe55751b04ea28837a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: b9db5ada33d0afafa68c8f63f1fec554fb79c03c) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: fffe4d83c5e7d83801daa87697801317abcacc99) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 87ee9eafb60c6116750fcc3ab12120c9da131028) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@FiloSottile I updated the PR, which de-scoped it quite a bit. Let me know if this is closer to what you had in mind, and if so I can squash the commits.
This PR (HEAD: 56c74ec2f26110b5850b4355ab44b527daa21e5a) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Filippo Valsorda:
Patch Set 9: Run-TryBot+1 Code-Review+2
(1 comment)
Thanks! To update the commit message you need to update the title and body of the PR.
See https://golang.org/wiki/CommitMessage
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 9:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=a216d472
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Gobot Gobot:
Patch Set 9: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: da25f67d73e85f209a2a3ad7ea96054e8f330247) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: bba6e2eb3bdc133918e16dd0f3f62a80fd0b7de8) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/crypto/+/216423 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
@FiloSottile sorry this slipped through the cracks, hopefully I have addressed your concerns.
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 9:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=a216d472
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 9: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Emmanuel Odeke:
Patch Set 12: Trust+1
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Emmanuel Odeke:
Patch Set 12: Run-TryBot+1
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 12:
TryBots beginning. Status page: https://farmer.golang.org/try?commit=5f741069
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 12: TryBot-Result+1
TryBots are happy.
Please don’t reply on this GitHub thread. Visit golang.org/cl/216423. After addressing review feedback, remember to publish your drafts!
Would be nice to have this. It would clean up my code a little. Also, kinda expected this already because x509.Certificate has a Raw field. Though, I get they're different types.
