build Remember INSTALLDIR on upgrade

Remember INSTALLDIR on upgrade

Open mxmauro opened this issue 3 years ago • 10 comments

When Go is upgraded on Windows, the previous installation location is not reused.

Installation directory is already stored in registry so half of the work is already done. The added elements retrieves the info from registry and updates INSTALLDIR.

Jan 30 '21 02:01 mxmauro

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Jan 30 '21 02:01 google-cla[bot]

@googlebot I signed it!

Jan 30 '21 02:01 mxmauro

This PR (HEAD: 9d7665bd1a64d8c3bdc0bb4c217d74a4ea4038c0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/build/+/288252 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

Jan 30 '21 02:01 gopherbot

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: A maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.