blog
blog copied to clipboard
golang
Fix link and improve wording
- Fix the
time.Afterlink so it shows properly - Improve the wording describing the
Queryfunction, so it's clearer to readers.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
ℹ️ Googlers: Go here for more info.
This PR (HEAD: 1e46612ea6e098fa9f776f048565075ef7ea5319) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Bryan C. Mills:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Bryan C. Mills:
Patch Set 1:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from si drake:
Patch Set 1:
How about:
In this example, the closure first computes the result of the call to
DoQuery, then attempts to send it without blocking by wrapping the send in aselectstatement with adefaultcase.
After rewriting it a couple of times, I came up with the following. It's slightly different from your recommendation, but uses the same sort of language. Thoughts?
In this example, the closure performs a non-blocking operation, by computing the result of the call to
DoQuery, and attempting to send the result on the channelchin aselectstatement, with adefaultcase.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from si drake:
Patch Set 1:
I've updated the time.After link to be [time.After] as suggested, and it works/looks fine locally. Once we've got the other wording finalised, I'll push an update.
Commit messages has also been amended as per the link sent.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from si drake:
Patch Set 1:
(3 comments)
Do I need to do something to have this re-reviewed, after addressing the comments, or is it just a waiting game?
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 1:
I'm not seeing your changes. Are you sure that you pushed them? Thanks.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: ce40f1a788f017bfeff07086a80a609ca94b285c) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from si drake:
Patch Set 1:
I'm not seeing your changes. Are you sure that you pushed them? Thanks.
Not sure what happened there, but it doesn't look like I comitted the changes (or I somehow rebased them out).
I've updated again and comitted. Let me know if there are any further changes to make.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 2:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 8ae6098a4b0988b1eacd8dda709c7f30e3747dff) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 1103f7125f47eeb1fee0117b40e38d61d347f576) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
This PR (HEAD: 5216487081e60efb404990dc8b15dca38bf444f6) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from si drake:
Patch Set 5:
(1 comment)
Should be good for another review at your leisure.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Bryan C. Mills:
Patch Set 5:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from si drake:
Patch Set 5:
I just did a little bit of research afer Bryan's last comment and it looks like my understanding, of what that block of code does, was wrong.
Without dragging this on, I think I might be able to add some extra context to this paragraph for future readers so they don't have the same misunderstanding.
How does that sound? Do you normally have some sort of timeframe for these?
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
This PR (HEAD: 82fd5c2e56173612491eaaefb7e46dd2fbf161b7) has been imported to Gerrit for code review.
Please visit https://go-review.googlesource.com/c/blog/+/235897 to see it.
Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info
Message from si drake:
Patch Set 5:
OK I've pushed another patch.
It's actually VERY similar to Bryan's, as I took some of the wording, but I think the reference to the result not being immediately available from DoQuery clears up the confusion.
Also perfectly happy to just go ahead with Bryan's last suggestion in it's entirety.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Ian Lance Taylor:
Patch Set 6:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
Message from Go Bot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/235897. After addressing review feedback, remember to publish your drafts!
This PR is being closed because golang.org/cl/235897 has been abandoned.
Closing because the content of x/blog moved to x/website (see CL 324270). If this change still applies, it'd need to be re-sent it to x/website. Thanks.