carbon icon indicating copy to clipboard operation
carbon copied to clipboard

Published 20 hours ago • verified publisher icon golang-module

Revert "Add VietName lunar calendar"

Open gouguoyin opened this issue 1 year ago • 3 comments

Reverts golang-module/carbon#221

gouguoyin avatar Jan 25 '24 13:01 gouguoyin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dd4b00c) 100.00% compared to head (cceac42) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2563      2553   -10     
=========================================
- Hits          2563      2553   -10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 25 '24 13:01 codecov[bot]

@gouguoyin why merge and revert feature/vi-lunar branch? Are there any problem with this branch?

culy247 avatar Jan 31 '24 04:01 culy247

@gouguoyin why merge and revert feature/vi-lunar branch? Are there any problem with this branch?

Do not recalculate Julian days in the Gregorian calendar, use calendar/Julian pakage for example

julian.FromGregorian(time.Date(year, time.Month(month), day, 0, 0, 0, 0, time.Local)).ToJulian().JD(0)

gouguoyin avatar Feb 04 '24 02:02 gouguoyin