migrate icon indicating copy to clipboard operation
migrate copied to clipboard

Add driver for pgx v5

Open treuherz opened this issue 2 years ago • 1 comments

Fixes #827

  • Move existing driver into database/pgx/v4
  • Make exported items into database/pgx into links to database/pgx/v4, marked as Deprecated
  • Mark defunct ErrDatabaseDirty as Deprecated - no code returns it
  • Bump pgx/v4 dependency
  • Add test runs for newer Postgres versions

If you'd like the last couple of changes to be broken into a different PR then let me know.

treuherz avatar Nov 01 '22 16:11 treuherz

Coverage Status

Coverage: 58.526%. Remained the same when pulling 1ecd0a871e4c4bbb61165ed550a7a5c3463c47f1 on treuherz:feature/pgxv5 into 8ec04221b49d69b123b39b9bc9b81774ee5b760e on golang-migrate:master.

coveralls avatar Nov 01 '22 16:11 coveralls

Hey! Quick bump from me? I'm currently running this branch to allow me to use pgx and golang-migrate together. (thanks btw!)

Any updates on getting this merged? 😇

koenbollen avatar Dec 14 '22 15:12 koenbollen

Rebased on top of master

treuherz avatar Dec 16 '22 14:12 treuherz

Any updates on getting this merged? Appreciate everyone's time.

mprimeaux avatar Jan 07 '23 01:01 mprimeaux

Please some prio 🙏

pmorelli92 avatar Jan 25 '23 13:01 pmorelli92

Any updates on this PR please?

franchb avatar Feb 05 '23 07:02 franchb

Any updates please???

MNovruzov avatar Feb 20 '23 12:02 MNovruzov

Hi @dhui. Would you mind reviewing and consider an approval? We have quite a few platforms waiting for this PR to be merged. Your help, and the help of any maintainer, is greatly appreciated.

mprimeaux avatar Mar 04 '23 18:03 mprimeaux

Rebased on top of master again to fix conflicts, and bumped pgx minor versions again.

@vincentdaniel it was nice of you to approve this last time, but it didn't look like that granted mergeability, is that correct?

treuherz avatar Mar 14 '23 09:03 treuherz

@treuherz correct, I am not maintainer of the project but I tried my luck anyway to see 🙈

vincentdaniel avatar Mar 14 '23 09:03 vincentdaniel

Implemented comments, rebased on master again to resolve go.mod conflicts.

treuherz avatar Mar 17 '23 17:03 treuherz

can we merge/release this?

kriswill avatar Apr 03 '23 18:04 kriswill