migrate icon indicating copy to clipboard operation
migrate copied to clipboard

Published 20 hours ago • verified publisher icon golang-migrate

ClickHouse driver V2 support

Open kshvakov opened this issue 2 years ago • 10 comments

kshvakov avatar Feb 04 '22 12:02 kshvakov

I can remove V1 support, maybe it will even be better for new users

kshvakov avatar Feb 07 '22 08:02 kshvakov

hello, it was fixed in #707

sergey-telpuk avatar Feb 28 '22 07:02 sergey-telpuk

Someone please merge this PR

makeavish avatar Mar 02 '22 19:03 makeavish

@sergey-telpuk https://github.com/golang-migrate/migrate/pull/707 was not merged so can't say that it was fixed. Maybe you forgot to merge. Please merge the PR so that we can use it.

makeavish avatar Mar 02 '22 19:03 makeavish

@sergey-telpuk #707 was not merged so can't say that it was fixed. Maybe you forgot to merge. Please merge the PR so that we can use it.

yes, I'm waiting for the approval PR

sergey-telpuk avatar Mar 02 '22 20:03 sergey-telpuk

I did miss this PR and did something similar to you, except I didn't keep support for v1. Your change looks good for me and includes almost all my changes. I have just added some backquotes around table and database names, but I suppose people should not try the devil, so no need to update. I did use named place holders instead of preparing a request, but your solution is good too.

Tested on Go 1.18.

vincentbernat avatar Mar 21 '22 18:03 vincentbernat

I can remove V1 support, maybe it will even be better for new users

If you remove V1 support and resolve the conflicts, I'm more than happy to give it a look and merge it within days. 👍🏻

Fontinalis avatar Apr 27 '22 17:04 Fontinalis

@kshvakov Please remove V1 support and resolve conflicts so that this can be reviewed and merged.

makeavish avatar Jan 09 '23 16:01 makeavish

It seems that #723 is a PR without V1.

vincentbernat avatar Jan 09 '23 17:01 vincentbernat

Any update on getting this merged?

tjsampson avatar Aug 27 '23 03:08 tjsampson