migrate
migrate copied to clipboard
golang-migrate
Extended posgres Drop() with type dropping
Closes #626
Fixes that Migrate.Drop() is not clearing the database properly in both the postgres and pgx database driver.
Pull Request Test Coverage Report for Build 1459982313
- 76 of 84 (90.48%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.2%) to 57.978%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| database/pgx/pgx.go | 38 | 42 | 90.48% |
| database/postgres/postgres.go | 38 | 42 | 90.48% |
| <!-- | Total: | 76 | 84 |
| Totals | |
|---|---|
| Change from base Build 1424470324: | 0.2% |
| Covered Lines: | 3779 |
| Relevant Lines: | 6518 |
💛 - Coveralls
Ah missed that issue. Created a duplicate.
Yes sometimes we don't care or need to care about the Down. Down is specifically only for things created by Up. Down can be very slow a large database/complex reverts. Using the Drop without this fix leaves the database in a state that cannot be fixed with migrate.
@dhui Can you please have another look? I'm staring to get out of context again.
just got bit by this. would be great if this could be reviewed and merged soon!
