migrate
migrate copied to clipboard
golang-migrate
Support for specifying warehouse and role in snowflake URL string
@dhui There was an issue I came across with warehouse name and role not specified in URL string when trying to connect via code which I hadn't encountered earlier. Can you please approve ?
Pull Request Test Coverage Report for Build 792
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 53.38%
| Totals | |
|---|---|
| Change from base Build 785: | 0.0% |
| Covered Lines: | 2614 |
| Relevant Lines: | 4897 |
💛 - Coveralls
@dhui Any comments on this ? Otherwise we can merge. It's tested against hosted snowflake instance.
@dhui Any more comments ? I added support so that snowflake driver can execute multiple queries in single migration file. Also removed the 'computeLineFromPos' function in snowflake.go, as it wasn't being hit anytime.
I need this functionality for a project I'm working on in the next week. If it's reasonable that this could get merged I would not have to fork and re-implement, but I understand there may be some outstanding issues that need to be resolved before this can go mainstream. I would be happy to help contribute if it would get this feature into the main release.
