migrate icon indicating copy to clipboard operation
migrate copied to clipboard

Implement WithConnection for pgx driver

Open GAlexIHU opened this issue 1 year ago • 2 comments

Contents

Implements WithConnection method for pgx driver

Notes for reviewer

As originally mentioned in this Issue calling .Close also closes the underlying pool not just the connection used which might not be desired in some cases.

The changes mirrors the implementation in the other drivers, e.g. https://github.com/golang-migrate/migrate/blob/master/database/postgres/postgres.go#L68

GAlexIHU avatar Sep 10 '24 11:09 GAlexIHU

Coverage Status

coverage: 56.361% (+0.04%) from 56.319% when pulling ce0013366ccca8ac41b2c02529dae8b07eff2477 on GAlexIHU:feat/pgx-withconn into 555501f7cdbf52a34bf66d49eb37eb72b22b2a85 on golang-migrate:master.

coveralls avatar Sep 10 '24 11:09 coveralls

Hey @mattes @dhui! Sorry for poking you, but could you please take a look on this PR? Many thanks! 🙇🏻‍♂️

chrisgacsal avatar Oct 04 '24 09:10 chrisgacsal

closing due to inactivity

GAlexIHU avatar Nov 05 '25 14:11 GAlexIHU