jwt icon indicating copy to clipboard operation
jwt copied to clipboard

Published 20 hours ago • verified publisher icon golang-jwt

chore: remove unused claims in table driven test - part2

Open gkech opened this issue 2 years ago • 2 comments

Followup PR: https://github.com/golang-jwt/jwt/pull/212

Noticed that claims are not used in various table-driven tests around the project. With this PR we clean them up. Sorry for not noticing in https://github.com/golang-jwt/jwt/pull/212.

gkech avatar Jun 08 '22 08:06 gkech

Wouldn't it make more sense to actually check the claims instead of removing them?

oxisto avatar Jun 08 '22 09:06 oxisto

Wouldn't it make more sense to actually check the claims instead of removing them?

Hello @oxisto, thank you for your comment.

Initially, I was thinking the same but I wasn't sure if the lack of claims checking was intentional e.g. because they are covered in another unit test.

gkech avatar Jun 09 '22 07:06 gkech