ComfyUI_VLM_nodes icon indicating copy to clipboard operation
ComfyUI_VLM_nodes copied to clipboard
Published 10 months ago • verified publisher icon gokayfem

Fixes installation on MacOS on Apple Sillicon

Open wouterdebie opened this issue 1 year ago • 10 comments

  • Bumps py-cpuinfo to version 9
  • Since there are no precompiled llama-cpp-python wheels available for MacOS on Apple Sillicon, this installs direclty from pypiy.org

wouterdebie avatar Apr 19 '24 20:04 wouterdebie

I'm a total noob when it comes to ComfyUI. What exactly do you want me to do? And how do I measure the startup time?

wouterdebie avatar Apr 19 '24 20:04 wouterdebie

when you start comfyui it gives you loading time for each node in the command line next to nodes

gokayfem avatar Apr 19 '24 20:04 gokayfem

Gotcha!

   0.3 seconds: /Users/wouter.de.bie/prjs/others/c2/ComfyUI/custom_nodes/ComfyUI_VLM_nodes

wouterdebie avatar Apr 19 '24 20:04 wouterdebie

thanks, i will check for windows and linux and after that i will merge.

gokayfem avatar Apr 19 '24 20:04 gokayfem

Great! If things are slow on Windows, I could make the version conditional.

wouterdebie avatar Apr 19 '24 20:04 wouterdebie

py-cpuinfo version 9 is slowing down loading time about 1.1 second on Windows.

gokayfem avatar Apr 20 '24 02:04 gokayfem

I just pushed a new version that differentiates between arm64 and x86_64. Hope this works!

wouterdebie avatar Apr 20 '24 17:04 wouterdebie

The problem still there. Requirements still demand 3.3 version, while only version 9 works.

tombearx avatar Jun 25 '24 21:06 tombearx

Some nodes require packages dependent on py-cpuinfo > 3. Is there a particular reason that 1 second is a concern? Many nodes on the ComfyUI registry have import times upwards of 2 seconds.

Taithrah avatar Aug 29 '24 19:08 Taithrah