composer icon indicating copy to clipboard operation
composer copied to clipboard

Docker builds not using cache

Open christopherperry opened this issue 6 years ago • 7 comments

Every build through docker does a lot of things that could probably be cached. I couldn't get a local build to work, so iterating via the docker build is quite a pain.

christopherperry avatar Apr 05 '18 17:04 christopherperry

You mean ci/build.sh right?

Just want to make sure you're not talking about dockerized integration of Composer in your project :)

artem-zinnatullin avatar Apr 05 '18 18:04 artem-zinnatullin

I see a PR from you, so I can assume you mean ci/build.sh

artem-zinnatullin avatar Apr 05 '18 18:04 artem-zinnatullin

Yeah, build is not as fast as I'd like it to be,

Quick suggestion tho: you don't need to run it through Docker every time, you can build it once so we have generated HTML report files and then just iterate over composer module with Gradle/IDE: ./gradlew build

artem-zinnatullin avatar Apr 05 '18 19:04 artem-zinnatullin

@artem-zinnatullin Sorry for the late reply, yes I'm talking about ci/build.sh

christopherperry avatar Apr 05 '18 22:04 christopherperry

Quick suggestion tho: you don't need to run it through Docker every time, you can build it once so we have generated HTML report files and then just iterate over composer module with Gradle/IDE: ./gradlew build

Awesome. Ok. Maybe that should be added to the README? I tried to build via Gradle and had a test failure which I found confusing so I reached for the docker build.

christopherperry avatar Apr 05 '18 22:04 christopherperry

Let me try to optimize Docker build first :)

artem-zinnatullin avatar Apr 05 '18 22:04 artem-zinnatullin

It's a bit tricky to cache properly, I'm gonna do few incremental improvements first

artem-zinnatullin avatar Apr 23 '18 07:04 artem-zinnatullin