heimdall icon indicating copy to clipboard operation
heimdall copied to clipboard

Published 20 hours ago • verified publisher icon gojek

fix: do not wait on zero retries

Open greut opened this issue 4 years ago • 4 comments

Closes #89 , /cc @xyluet

greut avatar Sep 16 '20 05:09 greut

Coverage Status

Coverage decreased (-8.9%) to 91.105% when pulling 560faa362c2f6121d2afb614c54f4b83f2136e2c on greut:fix/wait-when-no-retries into 2f1fd2700e9d549092e9c249e08be101a6a887c6 on gojek:master.

coveralls avatar Sep 16 '20 05:09 coveralls

Coverage Status

Coverage decreased (-8.9%) to 91.105% when pulling 560faa362c2f6121d2afb614c54f4b83f2136e2c on greut:fix/wait-when-no-retries into 2f1fd2700e9d549092e9c249e08be101a6a887c6 on gojek:master.

coveralls avatar Sep 16 '20 05:09 coveralls

Better to add test, an example from my issue should enough, then let the maintainer decide. :+1:

sunjayaali avatar Sep 16 '20 08:09 sunjayaali

ExampleWithRetrier is the test.

greut avatar Sep 16 '20 09:09 greut