Inigo Goiri

Results 19 comments of Inigo Goiri

Could we have a HADOOP JIRA just for the changes in commons? It could be something like: https://issues.apache.org/jira/browse/HADOOP-13144

This is a massive PR. I'm not sure if it is worth though. I would prefer to scope it too.

> Personally, I think this optimization should still be valuable, I hope that the submitted pr is not at the class level, at least at the moudle level. I wouldn't...

@slfan1989 this is a lot to review. Can we split it? Probably cleanup of the existing code and then one or two for the federation part.

Anybody else available for a review? Otherwise we go with this by the end of the week.

@ZanderXu please take a look at: https://issues.apache.org/jira/browse/HDFS-13522 @simbadzina added a design doc too: https://issues.apache.org/jira/secure/attachment/13046815/observer_reads_in_rbf_proposal_simbadzina_v1.pdf

No worries, you merged manually instead of merging the existing PR. It is fine.

I tend to agree that we should avoid not changing the previous behavior. Can we add one setting that allows keeping the old 0 for the default case and tune...