django-multiselectfield icon indicating copy to clipboard operation
django-multiselectfield copied to clipboard

Published 20 hours ago • verified publisher icon goinnn

Support Django 2.0

Open blag opened this issue 7 years ago • 9 comments

Closes #74.

blag avatar Jan 29 '18 02:01 blag

Coverage Status

Coverage increased (+0.1%) to 92.0% when pulling 3ea4abc1af268de7a09ecb1d64e89c3cd6e2d3fb on blag:django-2.0 into 94ff6e1c3a8cb4cf636f1ccb62f50a5e792a27fd on goinnn:master.

coveralls avatar Jan 29 '18 02:01 coveralls

Some of the comments on this question seem to indicate that this might be an error in the migration files.

If the main change is in multiselectfield/db/fields.py:105 value = self._get_val_from_obj(obj), it kind of makes sense that there might be a migration error somewhere.

Lyla-Fischer avatar May 15 '18 03:05 Lyla-Fischer

I have some changes here that allow for the example app to run using django 2.0 and runserver. The tests still fail in the same way, but it might be a hint as to what is going wrong.

Lyla-Fischer avatar May 15 '18 03:05 Lyla-Fischer

I upvoted this question which seems to have the same issue that we are running into. There's no solution posted.

Lyla-Fischer avatar May 15 '18 04:05 Lyla-Fischer

May I ask what the status is of this branch?

chlab avatar Jun 15 '18 14:06 chlab

@blag Isn't it value_from_object rather than val_from_object ? With Django 2.2, I get 'MultiSelectField' object has no attribute 'val_from_object'...

olivierdalang avatar Jul 18 '19 13:07 olivierdalang

Hi @blag , please check Travis errors, there seems to be several errors with some Django Version

tomasgarzon avatar Sep 13 '19 04:09 tomasgarzon

It appears this has been fixed.

jayvdb avatar Oct 05 '20 03:10 jayvdb

ping @goinnn / @blag . This can be closed?

jayvdb avatar Dec 26 '21 14:12 jayvdb