django-multiselectfield icon indicating copy to clipboard operation
django-multiselectfield copied to clipboard

run tests in github CI

Open olivierdalang opened this issue 10 months ago • 2 comments

Ported from https://github.com/olivierdalang/django-multiselectfield/blob/dj5/.github/workflows/tests.yaml as requested on https://github.com/goinnn/django-multiselectfield/issues/141#issuecomment-2056109635

Note that this is just the CI part, so it's expected to fail. The tests pass on my branch.

olivierdalang avatar Apr 17 '24 17:04 olivierdalang

Ok done !

olivierdalang avatar Apr 19 '24 15:04 olivierdalang

@goinnn Could you take a look at this and merge this PR first? Should be simple and risk free.

PetrDlouhy avatar Apr 19 '24 16:04 PetrDlouhy

@blag Could you please look at this PR first? I expect this is very easy to check. Then all other PRs would be tested before merging.

PetrDlouhy avatar May 20 '24 14:05 PetrDlouhy

I have some minor questions (still interested in the answers/responses even though I resolved the review comments) but nothing that would merit blocking this.

Thank you for your effort.

blag avatar May 20 '24 19:05 blag